multiple roles can be applied to each person #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solves the issue( #77 ) |
gaborcsardi
reviewed
Apr 1, 2020
More precise message Co-Authored-By: Gábor Csárdi <[email protected]>
|
@gaborcsardi Thank you for your comment and commit ! NEWS file is also updated. |
|
Thanks! I added some commits to this PR, which then did not show up. Seems like some GitHub bug or temporary glitch, but I merged this manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original implementation, multiple roles cannot be applied to role argument for functions such as desc$add_author(). This is because check_author_args() function called from add_author() calls is_string_or_null() for role argument. This checks whether the role is NULL or character vector with length of 1.
In the develop implementation for that I am creating pull request, role argument can be character vector with any length. Instead of is_string_or_null(), is_character_or_null() is implemented and used.
The following code is allowed in this implementation.