Thanks to visit codestin.com
Credit goes to github.com

Skip to content

better role handling in coerce_authors_at_r() #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 21, 2022
Merged

better role handling in coerce_authors_at_r() #115

merged 10 commits into from
Feb 21, 2022

Conversation

@dpprdan
Copy link
Contributor

@dpprdan dpprdan commented Oct 6, 2021

This PR should improve the handling of roles by coerce_authors_at_r().
My main assumptions underlying the code:

  • Author and Maintainer fields are not empty, as required by WRE (but not sure about Bioconductor for example)
  • Author and Maintainer contain strings that can be parsed by as.person() (violated by packages with an Author file, e.g. igraph, so probably needs an appropriate error message)
  • Only one Maintainer, as required by WRE (again dunno about Bioconductor)

closes #114

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #115 (1f175a2) into main (df76490) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 1f175a2 differs from pull request most recent head 0747526. Consider uploading reports for the commit 0747526 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   97.40%   97.50%   +0.10%     
==========================================
  Files          18       18              
  Lines        1154     1164      +10     
==========================================
+ Hits         1124     1135      +11     
+ Misses         30       29       -1
Impacted Files Coverage Δ
R/authors-at-r.R 91.98% <100.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df76490...0747526. Read the comment docs.

@gaborcsardi
Copy link
Member

Thanks! I'll review and add this before the next release. Which might take a few months, because desc was just updated about a week ago. Hopefully that is OK.

@dpprdan
Copy link
Contributor Author

dpprdan commented Oct 7, 2021

No problem. I just added a few more changes, I hope the intent becomes clear from the code and the commit messages.

@gaborcsardi
Copy link
Member

Thanks much and sorry for the long wait!

@gaborcsardi gaborcsardi merged commit 60678ff into r-lib:main Feb 21, 2022
@dpprdan dpprdan deleted the coerce_authors branch February 21, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Maintainer not returned as author from DESCRIPTION with classic fields

3 participants

@dpprdan @codecov-commenter @gaborcsardi