Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use radix sorting for order() in as_list() #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use radix sorting for order() in as_list() #40

wants to merge 1 commit into from

Conversation

MichaelChirico
Copy link

The test suite broke as we tried updating 1.1.0 -> 1.2.0:

── Failure (test-map.R:247:3): Sorting keys ────────────────────────────────────
m$as_list(sort = TRUE) not identical to list(.d = 4, a = 1, b = 2, c = 3).
Names: 4 string mismatches
Component 1: Mean relative difference: 3
Component 2: Mean relative difference: 0.5
Component 3: Mean relative difference: 0.3333333
Component 4: Mean relative difference: 0.25

I'm not sure why this isn't showing up on CRAN or on your end.

But I do see method="radix" under sort explicitly elsewhere, and this does make tests pass for me, so I think this is a good change regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MichaelChirico