Thanks to visit codestin.com
Credit goes to github.com

Skip to content

generate expression xml parse data from full xml parse data #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 23, 2022
Merged

generate expression xml parse data from full xml parse data #1201

merged 6 commits into from
May 23, 2022

Conversation

@AshesITR
Copy link
Collaborator

Another 20% performance improvement by parsing the XML only once and creating the expression documents from the full document.

> system.time(get_source_expressions(test_file))
   user  system elapsed 
  2.099   0.001   2.099 
> devtools::load_all()
ℹ Loading lintr
> system.time(get_source_expressions(test_file))
   user  system elapsed 
  1.635   0.001   1.636

@AshesITR AshesITR requested a review from MichaelChirico May 23, 2022 19:05
AshesITR
AshesITR commented May 23, 2022
View reviewed changes
MichaelChirico
MichaelChirico reviewed May 23, 2022
View reviewed changes
@AshesITR AshesITR merged commit 0fe67b6 into main May 23, 2022
@AshesITR AshesITR deleted the get_source_expressions-performance branch May 23, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AshesITR @MichaelChirico