unused_import_linter() detects datasets from imports
#1549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndrajeetPatil
commented
Sep 22, 2022
| # SPECIAL usage is detected | ||
| expect_lint("library(magrittr)\n1:3 %>% mean()", NULL, linter) | ||
| # dataset is detected | ||
| expect_lint("library(dplyr)\nstarwars", NULL, linter) |
Collaborator
Author
There was a problem hiding this comment.
MichaelChirico
added a commit
that referenced
this pull request
Sep 24, 2022
Follow-up to #1549, the `Items` column has a funny format for some objects, per `?data`: ``` Where the datasets have a different name from the argument that should be used to retrieve them the index will have an entry like ‘beaver1 (beavers)’ which tells us that dataset ‘beaver1’ can be retrieved by the call ‘data(beaver)’. ```
IndrajeetPatil
added a commit
that referenced
this pull request
Sep 24, 2022
* Slightly improve dataset symbol detection Follow-up to #1549, the `Items` column has a funny format for some objects, per `?data`: ``` Where the datasets have a different name from the argument that should be used to retrieve them the index will have an entry like ‘beaver1 (beavers)’ which tells us that dataset ‘beaver1’ can be retrieved by the call ‘data(beaver)’. ``` * add test Co-authored-by: Indrajeet Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1508