New lengths_linter #1568
Merged
New lengths_linter #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshesITR
reviewed
Sep 30, 2022
IndrajeetPatil
previously approved these changes
Sep 30, 2022
IndrajeetPatil
approved these changes
Oct 1, 2022
Collaborator
IndrajeetPatil
left a comment
There was a problem hiding this comment.
One minor comment, but ready otherwise.
| `lapply(x, function(xi) sum(xi))` can be `lapply(x, sum)` and `purrr::map(x, ~quantile(.x, 0.75, na.rm = TRUE))` | ||
| can be `purrr::map(x, quantile, 0.75, na.rm = TRUE)`. Naming `probs = 0.75` can further improve readability. | ||
| * `redundant_equals_linter()` for redundant comparisons to `TRUE` or `FALSE` like `is_treatment == TRUE` (#1500, @MichaelChirico) | ||
| * `lengths_linter()` for encouraging usage of `lengths(x)` instead of `sapply(x, length)` (and similar) |
Collaborator
There was a problem hiding this comment.
Is this sentence complete?
(and other similar functions from apply and map families).
Collaborator
Author
There was a problem hiding this comment.
no need for a complete sentence IMO :)
76 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #884