Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove TODOs related to {waldo} update #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelChirico merged 10 commits into from
Sep 19, 2022
Merged

Remove TODOs related to {waldo} update #1518

MichaelChirico merged 10 commits into from
Sep 19, 2022

Conversation

@IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Aug 29, 2022

No description provided.

@IndrajeetPatil
Copy link
Collaborator Author

IndrajeetPatil commented Aug 29, 2022

@MichaelChirico I am not sure which test this is referring to:

lintr/tests/testthat/test-with.R

Lines 17 to 18 in efacfea

# TODO(michaelchirico): use plain expect_equal after waldo#133 makes it into a CRAN release
# Here, the environment()s are different because factories use them.

That's the only TODO that remains related to the {waldo} update.

@MichaelChirico
Copy link
Collaborator

MichaelChirico commented Aug 29, 2022

IINM that TODO's referring to this:

lintr/tests/testthat/test-with.R

Lines 26 to 27 in 5276c37

expect_silent(result <- all.equal(linters_with_tags("default"), linters_with_defaults()))
expect_true(result)

MichaelChirico
MichaelChirico reviewed Aug 29, 2022
View reviewed changes
@IndrajeetPatil IndrajeetPatil added this to the 3.0.2 milestone Sep 13, 2022
@IndrajeetPatil
Copy link
Collaborator Author

IndrajeetPatil commented Sep 16, 2022

@MichaelChirico This should be ready for approval now.

MichaelChirico
MichaelChirico reviewed Sep 19, 2022
View reviewed changes
MichaelChirico
MichaelChirico reviewed Sep 19, 2022
View reviewed changes
@MichaelChirico MichaelChirico merged commit 13f00c2 into main Sep 19, 2022
@MichaelChirico MichaelChirico deleted the waldo_todo branch September 19, 2022 08:16
@MichaelChirico MichaelChirico modified the milestones: 3.0.3, 3.1.0 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IndrajeetPatil @MichaelChirico