Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unnecessary loadNamespace() call for {rex} #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IndrajeetPatil merged 2 commits into from
Oct 19, 2022
Merged

Remove unnecessary loadNamespace() call for {rex} #1740

IndrajeetPatil merged 2 commits into from
Oct 19, 2022

Conversation

@IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Oct 19, 2022

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022 •
edited
Loading

Codecov Report

Merging #1740 (e1f51e6) into main (080613e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head e1f51e6 differs from pull request most recent head 14cd653. Consider uploading reports for the commit 14cd653 to get more accurate results

@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
+ Coverage   98.84%   98.87%   +0.02%     
==========================================
  Files         107      108       +1     
  Lines        4517     4615      +98     
==========================================
+ Hits         4465     4563      +98     
  Misses         52       52
Impacted Files Coverage Δ
R/exclude.R 100.00% <ø> (ø)
R/expect_lint.R 100.00% <ø> (ø)
R/backport_linter.R 100.00% <100.00%> (ø)
R/extract.R 100.00% <100.00%> (ø)
R/get_source_expressions.R 94.38% <100.00%> (ø)
R/indentation_linter.R 100.00% <100.00%> (ø)
R/lint.R 97.01% <100.00%> (-0.01%) ⬇️
R/make_linter_from_regex.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil IndrajeetPatil removed the request for review from MichaelChirico October 19, 2022 17:41
@IndrajeetPatil IndrajeetPatil merged commit 78eb49f into main Oct 19, 2022
@IndrajeetPatil IndrajeetPatil deleted the rm_rex_testthat branch October 19, 2022 18:01
@IndrajeetPatil IndrajeetPatil added the internals Issues related to inner workings of lintr, i.e., not user-visible label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees

No one assigned

Labels

internals Issues related to inner workings of lintr, i.e., not user-visible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IndrajeetPatil @codecov-commenter @AshesITR