Improve formatting for fixed_regrex_linter() tests
#1860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed_regrex_linter()fixed_regrex_linter() tests
IndrajeetPatil
commented
Dec 18, 2022
| # up in practice is for '\<', which is a special character in default | ||
| # regex but not in PCRE. Empirically relevant for HTML-related regex e.g. \\<li\\> | ||
|
|
||
| special_char <- function() { |
Collaborator
Author
There was a problem hiding this comment.
Temporary name. We should change it to something for informative.
Codecov Report
@@ Coverage Diff @@
## main #1860 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 112 112
Lines 4823 4823
=======================================
Hits 4768 4768
Misses 55 55 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MichaelChirico
approved these changes
Dec 19, 2022
Collaborator
|
Great change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.