Improve deprecation messages for find_*()
#1861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndrajeetPatil
commented
Dec 18, 2022
| #' @noRd | ||
| find_line_fun <- function(content, newline_locs) { | ||
| function(line_number) { | ||
| lintr_deprecated("find_line_fun", new = "XPath logic and xml_nodes_to_lints()", version = "3.0.0") |
Collaborator
Author
There was a problem hiding this comment.
Is version correct?
Codecov Report
@@ Coverage Diff @@
## main #1861 +/- ##
==========================================
- Coverage 98.85% 98.85% -0.01%
==========================================
Files 112 112
Lines 4815 4811 -4
==========================================
- Hits 4760 4756 -4
Misses 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AshesITR
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1858