exclude deprecated linters from overall list & tag-specific lists #1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Fixing the tests will be a bit of a pain. Hold off for now. |
Codecov Report
@@ Coverage Diff @@
## main #1958 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 113 113
Lines 4980 4980
=======================================
Hits 4928 4928
Misses 52 52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
Author
|
ready for review now that tests are passing |
AshesITR
reviewed
Apr 10, 2023
| expect_true(exists("linters", envir = help_env), info = "?linters exists") | ||
|
|
||
| # NB: objects in help_env are class Rd, see ?as.character.Rd (part of 'tools') | ||
| rd_as_string <- function(rd) paste(as.character(rd), collapse = "") |
Collaborator
Author
There was a problem hiding this comment.
the whole test is still a bit of a mess to understand from scratch, this is a small improvement :)
AshesITR
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1956