Thanks to visit codestin.com
Credit goes to github.com

Skip to content

handle multiline case for function_left_parentheses_linter #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelChirico merged 13 commits into from
Apr 11, 2023
Merged

handle multiline case for function_left_parentheses_linter #1960

MichaelChirico merged 13 commits into from
Apr 11, 2023

Conversation

@MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Apr 10, 2023 •
edited
Loading

Closes #1953

Open to suggestions for avoiding the horrible range_end_xpath but I wasn't seeing anything...

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023 •
edited
Loading

Codecov Report

Merging #1960 (01f9941) into main (9038957) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 01f9941 differs from pull request most recent head 99e5dab. Consider uploading reports for the commit 99e5dab to get more accurate results

@@           Coverage Diff           @@
##             main    #1960   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         113      113           
  Lines        4980     4990   +10     
=======================================
+ Hits         4928     4938   +10     
  Misses         52       52
Impacted Files Coverage Δ
R/function_left_parentheses_linter.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

MichaelChirico
MichaelChirico commented Apr 10, 2023
View reviewed changes
AshesITR
AshesITR reviewed Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question: Is it syntactically valid to have more than one line of difference?

x <- function

() {
  42L
}

@MichaelChirico
Copy link
Collaborator Author

MichaelChirico commented Apr 10, 2023

Is it syntactically valid to have more than one line of difference?

yes, that parses

AshesITR
AshesITR reviewed Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add a test case for the case spanning more than two lines?
Rest looks good to me.

@MichaelChirico
Copy link
Collaborator Author

MichaelChirico commented Apr 11, 2023

Do you want to add a test case for the case spanning more than two lines?

I think not necessary, b/c the XPath condition is just = vs !=, and insensitivity to newlines is a language feature -- current tests are enough IMO.

@MichaelChirico MichaelChirico merged commit 2b06c52 into main Apr 11, 2023
@MichaelChirico MichaelChirico deleted the flp-case branch April 11, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error in rep.int(character, length) : invalid 'times' value

4 participants

@MichaelChirico @codecov-commenter @AshesITR