Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Jul 3, 2023

Follow-up to #1998 -- actually as.data.table() experiences a similar regression from v3.0.2 to HEAD, just that it's not breaking any tested downstreams. I have relied on this behavior in interactive cases, though.

I think the enigmatic Enhances is the proper place for the new dependency, per WRE:

‘Enhances’... lists packages “enhanced” by the package at hand, e.g., by providing methods for classes from these packages...

OTOH we might just "keep it simple" and put data.table in Suggests.


Currently as.data.table() works very poorly b/c of dispatch:

data.table::as.data.table(lintr::lint(text="a=1", linters=lintr::assignment_linter()))
#                            <text>
# 1:                         <text>
# 2:                              1
# 3:                              2
# 4:                          style
# 5: Use <-, not =, for assignment.
# 6:                            a=1
# 7:                      <list[1]>
# 8:              assignment_linter

@MichaelChirico MichaelChirico added this to the 3.1.0 milestone Jul 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1999 (7fea9fb) into main (6f1a924) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7fea9fb differs from pull request most recent head ce5895e. Consider uploading reports for the commit ce5895e to get more accurate results

@@           Coverage Diff           @@
##             main    #1999   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         113      113           
  Lines        5001     5003    +2     
=======================================
+ Hits         4929     4931    +2     
  Misses         72       72           
Impacted Files Coverage Δ
R/methods.R 100.00% <100.00%> (ø)

@AshesITR AshesITR merged commit ba896ef into main Jul 4, 2023
@IndrajeetPatil IndrajeetPatil deleted the asdt branch September 27, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants