Thanks to visit codestin.com
Credit goes to github.com

Skip to content

export ids_with_token() and with_id() #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2019
Merged

export ids_with_token() and with_id() #394

merged 2 commits into from
Sep 3, 2019

Conversation

@stufield
Copy link
Contributor

  • rm ids_with_token and with_id from 'utils.R'
  • add new files 'ids_with_token.R' and 'with_id.R'
  • roxygen updated NAMESPACE for new exports
  • new docs; combined into 'ids_with_tokens.Rd'
  • add *.R files to Collate entry of DESCRIPTION
  • add 'Encoding' field to DESCRIPTION to avoid Roxygen warning
  • Update NEWS.md
  • Closes Writing Own Linters ... ids_with_token() Not Exported #297

@stufield
New Exports; ids_with_token() and with_id()
c91b443 
- rm 'ids_with_token' and 'with_id' from utils.R
- add new files 'ids_with_token.R' and 'with_id.R'
- roxygen updated NAMESPACE for new exports
- new docs; combined into 'ids_with_tokens.Rd'
- add *.R files to Collate entry of DESCRIPTION
- add 'Encoding' field to DESCRIPTION to avoid Roxygen warning
- Update NEWS.md
- Closes #297
@stufield stufield requested a review from jimhester as a code owner August 13, 2019 22:19
@codecov
Copy link

codecov bot commented Aug 30, 2019 •
edited
Loading

Codecov Report

Merging #394 into master will increase coverage by 0.45%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #394      +/-   ##
=========================================
+ Coverage   81.74%   82.2%   +0.45%     
=========================================
  Files          44      43       -1     
  Lines        1972    1871     -101     
=========================================
- Hits         1612    1538      -74     
+ Misses        360     333      -27
Impacted Files Coverage Δ
R/utils.R 69.86% <ø> (-2.43%) ⬇️
R/with_id.R 100% <100%> (ø)
R/ids_with_token.R 83.33% <83.33%> (ø)
R/zzz.R 0% <0%> (ø) ⬆️
R/namespace.R
R/cyclocomp_linter.R
R/declared_functions.R
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 218fb7d...afd10ef. Read the comment docs.

jimhester
jimhester previously approved these changes Aug 30, 2019
View reviewed changes
@stufield
Copy link
Contributor Author

stufield commented Sep 2, 2019 •
edited
Loading

Hey @jimhester, pretty sure I'm allowed to merge this PR myself, but unsure of proper "etiquette". I see you've merged 'master' into this PR to pick up any trailing commits, so I imagine the sooner the better. If I should merge, which style merge? Default? Squashing? I know some have pretty strong opinions about that sort of thing re: the commit history.

@jimhester jimhester merged commit 28a3765 into r-lib:master Sep 3, 2019
@jimhester
Copy link
Member

You could merge it, generally we squash PRs unless there are only a few well separated commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimhester jimhester jimhester approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Writing Own Linters ... ids_with_token() Not Exported

2 participants

@stufield @jimhester