use linter names in lint() results #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Already added a test for #660 in combination with custom linter names. |
|
Hmm sadly GitHub hat a merge conflict in |
MichaelChirico
approved these changes
Dec 5, 2020
9 tasks
AshesITR
added a commit
that referenced
this pull request
Dec 6, 2020
MichaelChirico
pushed a commit
that referenced
this pull request
Dec 6, 2020
* de-lint test-absolute_path_linter.R * de-lint test-exclusions.R * de-lint test-extraction_operator_linter.R * de-lint test-get_source_expressions.R * de-lint test-implicit_integer_linter.R * de-lint test-nonportable_path_linter.R * de-lint test-object_name_linter.R * de-lint test-pipe_continuation_linter.R * de-lint test-semicolon_terminator_linter.R * de-lint test-settings.R * de-lint test-T_and_F_symbol_linter.R * de-lint test-todo_comment_linter.R * de-lint test-undesirable_function_linter.R * de-lint test-undesirable_operator_linter.R * de-lint test-unneeded_concatenation_linter.R * bump cyclocomp limit up to 30 for lint() caused by #673 * fix test failure on non-english locale * fix test failure on non-english locale * remove most context() calls in touched files test-exclusions.R was not touched since it contains 3 calls (and will be split by #660)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #664