-
Couldn't load subscription status.
- Fork 195
add semicolon_terminator_linter to default linters #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for requesting my review. I'm somewhat nervous about adding additional linters to the Nonetheless, if we set up an issue/project to define the changes we want to make before the next big release, and include "expand the There are a number of other big changes happening to lintr at the moment, so it may make sense to document the plans for leading-in to lintr-v3. WDYT @jimhester |
|
I think there are enough changes we can make the next release a compatibility breaking one and add some new default linters. One thing we could do (separate from this PR) is provide a way to easily opt into the previous default linters. |
|
@jimhester That sounds like a good idea. |
I would say, not a good idea. I think we want to maintain only one set of defaults in the long run -- our recommended defaults. The other behavior is just to help with back-compatibility in the short term. Eventually, people using it should migrate to using the recommended defaults, or adjusting their code to their own preferred defaults. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #683