Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@AshesITR
Copy link
Collaborator

@AshesITR AshesITR commented Dec 6, 2020

fixes #683

@AshesITR AshesITR requested a review from russHyde December 6, 2020 15:47
@russHyde
Copy link
Collaborator

russHyde commented Dec 7, 2020

Thanks for requesting my review. I'm somewhat nervous about adding additional linters to the default_linters since these constitute breaking changes: packages that use lintr's default_linters today may start failing tomorrow if this is merged (this happened when T/F linter was added to the defaults for example).

Nonetheless, if we set up an issue/project to define the changes we want to make before the next big release, and include "expand the default_linters to be consistent with tidyverse style-guidelines", I'm happy for this change to go through.

There are a number of other big changes happening to lintr at the moment, so it may make sense to document the plans for leading-in to lintr-v3. WDYT @jimhester

@jimhester
Copy link
Member

I think there are enough changes we can make the next release a compatibility breaking one and add some new default linters.

One thing we could do (separate from this PR) is provide a way to easily opt into the previous default linters.

@AshesITR
Copy link
Collaborator Author

AshesITR commented Dec 7, 2020

@jimhester That sounds like a good idea.
What about an option lintr.defaults maybe containing a version number or something?

@MichaelChirico
Copy link
Collaborator

What about an option lintr.defaults maybe containing a version number or something?

I would say, not a good idea. I think we want to maintain only one set of defaults in the long run -- our recommended defaults. The other behavior is just to help with back-compatibility in the short term. Eventually, people using it should migrate to using the recommended defaults, or adjusting their code to their own preferred defaults.

Copy link
Collaborator

@russHyde russHyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AshesITR AshesITR merged commit e759d2a into master Dec 8, 2020
@MichaelChirico MichaelChirico deleted the feature/semicolon_linter branch March 21, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don’t put ; at the end of a line, and don’t use ; to put multiple commands on one line.

5 participants