New pipe_call_linter enforcing calls (not symbols) in magrittr pipes #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far. Can we also add a negative test for just to be sure symbols are allowed in curly braces? |
|
does that code actually do anything?
…On Wed, May 19, 2021, 1:05 PM AshesITR ***@***.***> wrote:
Looks good so far. Can we also add a negative test for
x %>% { foo }
just to be sure symbols are allowed in curly braces?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#801 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2BA5IOSGGGMA64XNIOGS3TOQKYLANCNFSM45D7LYKQ>
.
|
|
This minimal code returns foo from the chain. |
|
that looks more reasonable to test as a minimal usage example. I'll test &
add it tomorrow.
…On Thu, May 20, 2021, 1:50 AM AshesITR ***@***.***> wrote:
This minimal code returns foo from the chain.
However, if this is correctly not linted, more complex code blocks should
also be covered - e.g.
x %>% {
tmp <- .
bla <- foo %>% unrelated_stuff(tmp)
my_combination_fun(tmp, bla)
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#801 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2BA5PXAPVKEPRVQCZENFLTOTEMFANCNFSM45D7LYKQ>
.
|
|
Updated now. Thanks! |
AshesITR
approved these changes
May 20, 2021
76 tasks
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces the following section of the tidyverse style guide:
https://style.tidyverse.org/pipes.html#no-arguments