Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Sep 26, 2025

Fix #2914

MWE

@maelle

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Sep 26, 2025

@maelle
Copy link
Collaborator Author

maelle commented Sep 26, 2025

https://68d644ca6f509ad95baa41de--pkgdown-dev.netlify.app/dev/llms.txt -- I wonder whether the preview workflow should gain the ability to set "" as an URL so that links in the preview would be to the preview.

@maelle maelle changed the title feat: build Markdown oages for all pages feat: build Markdown pages for all pages Sep 26, 2025
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for working on this!

About how long does this extra step take for pkgdown itself? (i.e. how much overhead does this add?)

@maelle
Copy link
Collaborator Author

maelle commented Oct 7, 2025

Something is wrong with my benchmark:

benchmark <- bench::mark(
    {fs::dir_delete("docs");pkgdown::build_site(".", lazy = FALSE, preview = FALSE)},
    {fs::dir_delete("docs");pkgdown::build_site(".", lazy = FALSE, preview = FALSE, override = list(template = list("build-md" = FALSE)))}
)

then the median time is 1.3m for the former one, 1.18m for the latter one?!

@hadley
Copy link
Member

hadley commented Oct 7, 2025

@maelle given the long duration, I'd just use system.time().

@maelle
Copy link
Collaborator Author

maelle commented Oct 16, 2025

I gave up on perfect footnotes.

@maelle maelle marked this pull request as ready for review October 16, 2025 11:30

**deprecated**

`intro`: “Get Started�, which links to a vignette or article with
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not me getting encoding wrong 🫠

@maelle maelle requested a review from hadley October 16, 2025 11:33
@hadley
Copy link
Member

hadley commented Oct 16, 2025

Do you want to add some tests for the individual convert functions, or should I? I think it'd be nice to get this into a release in the near future (e.g. early November?)

@maelle
Copy link
Collaborator Author

maelle commented Oct 17, 2025

@hadley

  • The snapshot test covered all things except one... that of course didn't work. Fixed now.
  • Happy for you to add more tests.

@hadley
Copy link
Member

hadley commented Oct 17, 2025

Oh we should also decide on some top-level parameter to turn this off for folks who don't want it. How about this?

llm-docs: false

And then in the future if we figure out other needed params we can put them under there:

llm-docs:
  some-new-option: 1
  some-other-option: foo

@maelle
Copy link
Collaborator Author

maelle commented Oct 17, 2025

Ah yes definitely important!! I like your suggestion.

@hadley hadley changed the title feat: build Markdown pages for all pages Build documentation for LLMs Oct 17, 2025
{{#subtitle}}<h3>{{{.}}}</h3>{{/subtitle}}
{{#desc}}<div class="section-desc">{{{desc}}}</div>{{/desc}}

{{#topics}}<dl>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maelle we were accidentally generating a definition list for every definition 😬

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch!! 🙈

@hadley hadley merged commit d63674a into main Oct 20, 2025
17 checks passed
@hadley hadley deleted the llms branch October 20, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add support for generating llms.txt files

3 participants