Thanks to visit codestin.com
Credit goes to github.com

Skip to content

put RStudio's Pandoc on the path during a check #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 9, 2021
Merged

put RStudio's Pandoc on the path during a check #132

merged 7 commits into from
Sep 9, 2021

Conversation

dpprdan
Copy link
Contributor

@dpprdan dpprdan commented Dec 7, 2020

This puts RStudio's Pandoc on the path during a check, #109.

I used Sys.getenv("RSTUDIO_PANDOC") instead of rmarkdown::pandoc_exec(), because the latter calls rmarkdown::find_pandoc(), which

searches for pandoc from the environment variable RSTUDIO_PANDOC (the RStudio IDE will set this variable to the directory of Pandoc bundled with the IDE), the environment variable PATH, and the directory ~/opt/pandoc/.

This approach avoids an Imports dependency on rmarkdown.

@dpprdan dpprdan mentioned this pull request Feb 14, 2021
Closed
@dpprdan
Copy link
Contributor Author

dpprdan commented Jun 15, 2021

I made a small change (similar to r-lib/urlchecker#11), so that RStudio's pandoc is put on the PATH only if it is not already (assuming that users prefer to have the pandoc on the PATH that they deliberately installed over RStudio's).

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021 •
edited
Loading

Codecov Report

Merging #132 (5e352a9) into master (dc4bbdc) will decrease coverage by 0.11%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   76.26%   76.15%   -0.12%     
==========================================
  Files          18       18              
  Lines         906      910       +4     
==========================================
+ Hits          691      693       +2     
- Misses        215      217       +2
Impacted Files Coverage Δ
R/background.R 96.87% <50.00%> (-1.52%) ⬇️
R/package.R 95.06% <50.00%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc4bbdc...5e352a9. Read the comment docs.

@gaborcsardi
Copy link
Member

Thanks!

@gaborcsardi gaborcsardi merged commit 22e242d into r-lib:master Sep 9, 2021
@gaborcsardi gaborcsardi mentioned this pull request Sep 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dpprdan @codecov-commenter @gaborcsardi