Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@IndrajeetPatil
Copy link
Collaborator

Some alternatives are more efficient or avoid unnecessary function calls.

IndrajeetPatil and others added 3 commits September 14, 2022 01:01
Some alternatives are more efficient or avoid unnecessary function calls.

And also cover some more integer literals.
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Merging #1000 (9841f9c) into main (4398297) will decrease coverage by 0.01%.
The diff coverage is 94.59%.

@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
- Coverage   90.34%   90.33%   -0.02%     
==========================================
  Files          47       47              
  Lines        2694     2690       -4     
==========================================
- Hits         2434     2430       -4     
  Misses        260      260              
Impacted Files Coverage Δ
R/addins.R 14.28% <0.00%> (ø)
R/utils-navigate-nest.R 81.48% <ø> (ø)
R/compat-dplyr.R 92.85% <100.00%> (ø)
R/detect-alignment.R 97.72% <100.00%> (-0.03%) ⬇️
R/expr-is.R 88.88% <100.00%> (-0.31%) ⬇️
R/io.R 88.67% <100.00%> (ø)
R/roxygen-examples.R 98.38% <100.00%> (-0.06%) ⬇️
R/rules-line-breaks.R 100.00% <100.00%> (ø)
R/rules-spaces.R 98.34% <100.00%> (ø)
R/rules-tokens.R 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 7ffef80 is merged into main:

  •   :ballot_box_with_check:cache_applying: 33.3ms -> 32.8ms [-5.14%, +1.81%]
  •   :ballot_box_with_check:cache_recording: 1.73s -> 1.72s [-1.29%, +0.46%]
  •   :ballot_box_with_check:without_cache: 4.55s -> 4.52s [-1.2%, +0.2%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, not so much speed improvement unfortunately, but cleaner code 👍 .

@IndrajeetPatil
Copy link
Collaborator Author

not so much speed improvement unfortunately

With time, they should accumulate to make a difference 🤞

@lorenzwalthert
Copy link
Collaborator

With time, they should accumulate to make a difference 🤞

Yes, for cummulated effects, there is #868 to compare to last release. Already a few percentage points faster 👍

@IndrajeetPatil IndrajeetPatil merged commit 38f0a3b into r-lib:main Sep 14, 2022
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3d6610e is merged into main:

  •   :ballot_box_with_check:cache_applying: 26.7ms -> 26.8ms [-0.26%, +0.59%]
  •   :ballot_box_with_check:cache_recording: 1.25s -> 1.25s [-0.25%, +0.59%]
  •   :ballot_box_with_check:without_cache: 3.29s -> 3.3s [-0.26%, +0.54%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil IndrajeetPatil deleted the lint_for_performance branch September 14, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants