-
Notifications
You must be signed in to change notification settings - Fork 72
Get rid of lints with performance implications #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of lints with performance implications #1000
Conversation
Some alternatives are more efficient or avoid unnecessary function calls. And also cover some more integer literals.
Codecov Report
@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
- Coverage 90.34% 90.33% -0.02%
==========================================
Files 47 47
Lines 2694 2690 -4
==========================================
- Hits 2434 2430 -4
Misses 260 260
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 7ffef80 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, not so much speed improvement unfortunately, but cleaner code 👍 .
With time, they should accumulate to make a difference 🤞 |
Yes, for cummulated effects, there is #868 to compare to last release. Already a few percentage points faster 👍 |
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3d6610e is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Some alternatives are more efficient or avoid unnecessary function calls.