Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fixes #43 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixes #43 #51

wants to merge 1 commit into from

Conversation

csgillespie
Copy link

@csgillespie csgillespie commented Sep 19, 2025 •
edited
Loading

fixes #43

  1. Minor refactor of url_db_from_package_rmd_vignettes to avoid package dependency
  2. Create a function to work with md files
  3. Bumped roxygen2

As we still return a db object, the print() and update functions work as expected.

Caveat

Technically, this MR doesn't actually solve the issue - it doesn't detect links in a qmd or Rmd file. Only an md file.
My gut feeling is

  1. If qmd/rmd functionality was added, this function would still be needed
  2. Adding qmd/rmd functionality would make the package more fragile to changes and updates. Currently the package is slim and just works.

Example

Using the files in this package

> url_md_check(".")
                       
! Warning: LICENSE.md:5:55 Moved
_Copyright © 2007 Free Software Foundation, Inc. &lt;<http://fsf.org/>&gt;_
                                                      ^~~~~~~~~~~~~~~
                                                      https://www.fsf.org/
✖ Error: LICENSE.md:595:6 Error: Timeout was reached [www.gnu.org]: Operation timed out after 3144 milliseconds with 0 bytes received
&lt;<http://www.gnu.org/philosophy/why-not-lgpl.html>&gt;.
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
! Warning: README.md:44:31 Moved
[Contributor Code of Conduct](https://r-lib.github.io/urlchecker/CODE_OF_CONDUCT.html).
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                              https://urlchecker.r-lib.org/CODE_OF_CONDUCT.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: Make urlchecker work outside of packages?

1 participant

@csgillespie