Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ummer-shell
Copy link
Contributor

@ummer-shell ummer-shell commented Aug 6, 2024

Contains updates to the batch API route, with corresponding tests for each of the changes:

  • Main logic change: Allows for fully defined and confidential tables in batch
    • When parameters fully defined for a request, runs sdk function directly.
    • Lookup function only used when parameters missing (e.g. no business_unit)
  • Refactor of batch route to have separate functions for parsing request parameters and running the functions
  • Allows for mixed results from batch:
    • Some requests can succeed and others fail in the same request
    • Helpful error messages so user can see which fail
  • Route mapping update
    • To shorten strings e.g. now '/events/raw' when was previously '/api/v1/events/raw'
    • SQL route mapping fix, was previously misnamed

@ummer-shell ummer-shell force-pushed the feature/batch-api-updates branch from b6a2c49 to cdc9317 Compare August 6, 2024 09:46
@ummer-shell
Copy link
Contributor Author

Update: Added sign-off to commits

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@GBBBAS GBBBAS self-requested a review August 6, 2024 11:26
@GBBBAS GBBBAS merged commit 7139621 into rtdip:develop Aug 6, 2024
@GBBBAS GBBBAS changed the title Feature/batch api updates Batch api updates Aug 6, 2024
@GBBBAS GBBBAS added the queries Tasks related to querying label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

queries Tasks related to querying

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants