Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ummer-shell
Copy link
Contributor

Two fixes to the batch api route

  1. Ensures threadpool worker environment variables parsed as integers (previously caused error since was parsed as strings)
  2. Created BatchBaseQueryParams class, rather than relying on BaseQueryParams. Otherwise, if DATABRICKS_SERVING_ENDPOINT is not defined, the batch route required an overall business_unit, data_security_level etc which did not make sense (as these were individually defined in each request within the batch).

@GBBBAS GBBBAS changed the title Feature/batch api fix Batch API updates Aug 19, 2024
@GBBBAS GBBBAS self-requested a review August 19, 2024 16:25
@GBBBAS GBBBAS added the queries Tasks related to querying label Aug 19, 2024
Signed-off-by: Ummer Taahir <[email protected]>
@ummer-shell
Copy link
Contributor Author

Amendment: Updated mkdocstrings versions due to regression issue (mkdocstrings/mkdocstrings#436)

@sonarqubecloud
Copy link

@GBBBAS GBBBAS merged commit 7cfc6c5 into rtdip:develop Aug 20, 2024
@ummer-shell ummer-shell deleted the feature/batch-api-fix branch September 2, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

queries Tasks related to querying

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants