Thanks to visit codestin.com
Credit goes to github.com

Skip to content

AMI Meter Data Model #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Apr 14, 2023
Merged

AMI Meter Data Model #126

merged 23 commits into from
Apr 14, 2023

Conversation

@vbayon
Copy link
Contributor

@vbayon vbayon commented Mar 30, 2023

First Commit. Review for structure and integration witn main line.

@GBBBAS GBBBAS changed the title First commit AMI Meter Data Model Apr 6, 2023
@GBBBAS GBBBAS requested review from GBBBAS and cching95 April 6, 2023 06:54
@GBBBAS GBBBAS added the data model Data Models label Apr 6, 2023
This was linked to issues Apr 6, 2023
Process Control Data Model - Analysis #71
Closed
AMI Meter Data Model - Analysis #72
Closed
AMI Meter Data Model - Documentation #73
Closed
AMI Meter Data Model - Produce python classes of Data Model #75
Closed
@GBBBAS GBBBAS removed a link to an issue Apr 6, 2023
Process Control Data Model - Analysis #71
Closed
GBBBAS
GBBBAS previously approved these changes Apr 6, 2023
View reviewed changes
@GBBBAS GBBBAS dismissed their stale review April 6, 2023 06:58

Didn't complete review

@GBBBAS
Copy link
Collaborator

GBBBAS commented Apr 6, 2023 •
edited
Loading

@vbayon

For the folder structure, I would suggest:

AMI Meters

  1. Create a file called rtdip_sdk/data_models/meters/ami_meters.py
  2. Move the classes MetaData, SeriesType, ModelType, UoMUsage, Usage, pjm_voltage_lvl into ami_meters.py. That way it would be simpler to import them in the code such as from rtdip_sdk.data_models.meters.ami_meters import MetaData
  3. Move the utils folder into the new folder rtdip_sdk/data_models/meters

Weather

  1. Move the constants/weather_constants.py file to rtdip_sdk/data_models/weather and call the file constants.py

Tests

  1. Change the test folders to reflect the above changes

Transformers

  1. The transformers folder - it would be good to understand the exact function of that code and whether it might be better positioned in the Pipelines section?

Build Errors

@cching95 Can you review the build errors to assess if there is something on our side that doesn't let Sonarcloud complete the scan?

@vbayon
Copy link
Contributor Author

vbayon commented Apr 6, 2023

@GBBBAS I will look into it!

GBBBAS
GBBBAS previously requested changes Apr 6, 2023
View reviewed changes
@vbayon
Copy link
Contributor Author

vbayon commented Apr 12, 2023

@GBBBAS I have done a big refactoring. Please check. Thanks! /V

@cching95 cching95 requested review from GBBBAS and cching95 April 14, 2023 15:32
@cching95 cching95 dismissed GBBBAS’s stale review April 14, 2023 15:41

changes have been resolved

@cching95 cching95 merged commit f8b1c30 into rtdip:develop Apr 14, 2023
GBBBAS pushed a commit that referenced this pull request Apr 10, 2025
@dh1542
#126: Merged new changes from develop
66ee048 
Signed-off-by: Dominik Hoffmann <[email protected]>
GBBBAS pushed a commit that referenced this pull request Apr 10, 2025
@dh1542
Merge pull request #126 from amosproj/merge/to-core
f0ff17a 
Merge to core repo clone #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cching95 cching95 cching95 approved these changes

@GBBBAS GBBBAS Awaiting requested review from GBBBAS

Assignees

No one assigned

Labels

data model Data Models

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AMI Meter Data Model - Produce python classes of Data Model AMI Meter Data Model - Documentation AMI Meter Data Model - Analysis

3 participants

@vbayon @GBBBAS @cching95