Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor "lib/lrama/reporter/states.rb" #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ydah merged 4 commits into from
Mar 3, 2025
Merged

Refactor "lib/lrama/reporter/states.rb" #593

ydah merged 4 commits into from
Mar 3, 2025

Conversation

@yui-knk
Copy link
Collaborator

@yui-knk yui-knk commented Mar 3, 2025

  • Removing local variable type annotations by removing intermediate tuple local variables
  • Remove needless #uniq method call
  • Move early return to the first

@yui-knk yui-knk requested a review from ydah March 3, 2025 06:39
ydah
ydah approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ydah ydah merged commit 9351d30 into ruby:master Mar 3, 2025
22 checks passed
@yui-knk yui-knk deleted the refactor_type branch March 3, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ydah ydah ydah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yui-knk @ydah