Don't create array for each lookahead-sensitive path candidate #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lookahead-sensitive path candidate was managed by array of `Path`. It needed to create array every time when new candidate was found. This was one of bottlenecks of `Lrama::Counterexamples#shortest_path`. This commit adds `parent` field to `Path` so that list of paths can be iterated by `parent`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lookahead-sensitive path candidate was managed by array of
Path. It needed to create array every time when new candidate was found. This was one of bottlenecks ofLrama::Counterexamples#shortest_path. This commit addsparentfield toPathso that list of paths can be iterated byparent.