Change clang version from 3.5 to last available for rbx in Debian #4213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
How about older version of Debian which would not have clang 3.7 available? You would need to figure out when 3.5 has been stoped and use it conditionally |
Author
|
@pkuczynski thanks, didn't think about it. How about just not fixing the version? I've updated PR |
Member
|
Would that work for any version of Debian and rbx? Maybe old rbx would require old version of clang? |
Member
|
rubinius has requirements in regards to the supported versions of clang, it is required to check each version in combination with each system to see what needs to change when - I know, this will be time consuming |
Member
|
Close in favour of #4325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4212