Fix Rubinius build on macOS with Homebrew #4328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should the llvm / clang parts be added to non-homebrew too? I've noticed this being needed in macports. Also, the llvm version required has changed in different versions of rbx, but I don't recall which. |
Contributor
|
(If I'm right about that, |
Member
Author
|
We should probably add it to port too, but I am not using ports myself, and not sure if we have a user base in there? Nobody reported the problem so far... |
Contributor
|
@pkuczynski I use macports. ;) |
Member
Author
|
Feel free to fire up a PR then :) |
Contributor
|
You've already gotten a few from me. Only so many spoons to spare. ;-)
|
|
thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://book.rubinius.com/manuscript/getting_rubinius.html
Fixes #4327