Add install from tag #4360
Merged
Add install from tag #4360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pending pull url
|
@mpapis ? |
|
all is fine, but wouldn't it be better to fix |
|
Seems to be two totally different things - `rvm_ruby_tag` is basically the "version" of a ruby; `rvm_ruby_repo_tag` is tag in the `git` sense (i.e. a nickname for a particular commit).
There's no guarantee that rubies will be stored in git repos or have git tags to mark their releases. Nor will all git tags be releases.
I tried to make a minimal change so as to *not* mess with the `rvm_ruby_tag` code. :-P
|
mpapis
reviewed
May 12, 2018
| rvm_ruby_repo_url="${repo_url:-}" | ||
| rvm_ruby_repo_branch="${branch_name:-}" | ||
| rvm_ruby_name="$ruby_name" | ||
| rvm_ruby_repo_tag="${rvm_ruby_repo_tag:-}" |
| elif [[ -n "${rvm_ruby_repo_branch:-}" ]] | ||
| then __from="${rvm_ruby_repo_branch}" | ||
| elif [[ -n "${rvm_ruby_repo_tag:-}" ]] | ||
| then __from="${rvm_ruby_repo_tag}" |
There was a problem hiding this comment.
how this is different from the earlier line __from="${rvm_ruby_tag#t}"? why can't we use that?
|
rvm_ruby_tag is the "name" of a release for display purposes. It may or
may not be stored as a git tag in the repo.
rvm_ruby_repo_tag (what I added) is specifically a git tag. It may or may
not be a release.
|
|
but they both end up in the |
|
In other parts, it makes a difference — e.g. the gem name & pulling the tag description from git. Or going around the tag-as-in-name lookup and just doing tag-as-in-git. |
mpapis
previously approved these changes
Jun 17, 2018
mpapis
approved these changes
Jun 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4312.
Changes proposed in this pull request:
--tagtorvm install