Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't spoil environment with '_system_*' variables #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2019
Merged

Don't spoil environment with '_system_*' variables #4584

merged 1 commit into from
Jan 22, 2019

Conversation

@VladRassokhin
Copy link
Contributor

@VladRassokhin VladRassokhin commented Jan 19, 2019 •
edited
Loading

Changes proposed in this pull request:

  • Don't spoil environment with _system_* variables
    I find it quite annoying to have strange env variables in CI environment where rvm is installed and loaded.
    Another question is why they don't have 'rvm' prefix.

@mpapis
Copy link
Member

mpapis commented Jan 22, 2019

those variables were supposed to not be leaked, but finding why they were is to much hassle, the fix is enough

@pkuczynski pkuczynski merged commit d105f0b into rvm:master Jan 22, 2019
@pkuczynski
Copy link
Member

Thanks!

@pkuczynski pkuczynski added this to the rvm-1.29.8 milestone Jan 22, 2019
@VladRassokhin
Copy link
Contributor Author

Thanks for fast-merging :)

@VladRassokhin VladRassokhin deleted the unset-_system-variables branch January 23, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpapis mpapis mpapis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

rvm-1.29.8

Development

Successfully merging this pull request may close these issues.

3 participants

@VladRassokhin @mpapis @pkuczynski