Always use the "from source" installation path for TruffleRuby#4708
Merged
pkuczynski merged 8 commits intorvm:masterfrom May 30, 2019
Merged
Always use the "from source" installation path for TruffleRuby#4708pkuczynski merged 8 commits intorvm:masterfrom
pkuczynski merged 8 commits intorvm:masterfrom
Conversation
2da1430 to
8d92d9e
Compare
pkuczynski
approved these changes
May 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TruffleRuby is a mix of "source" and "binary" Ruby in RVM terminology (#4297 (comment) for details).
So originally I added the "from source" code (#4406), and then later the "binary" code (#4456) as that's what TravisCI normally uses. However, the TravisCI code had to be modified anyway, so there is no need for handling TruffleRuby as a "binary" Ruby in RVM anymore.
I want to remove the code (which I added) for handling TruffleRuby as a "binary" Ruby. It's duplicating a fair bit of code, it does not work well, and introduces more ways to fail.
For example, one part which is fragile with binary rubies is for instance downloading with a timeout and trying all the remotes. I don't want that, I know exactly the one URL where TruffleRuby should be downloaded from for a given version.
Here are some issues that are all avoided by using the "source" installation path: #4633 #4497 #4506.
This PR effectively reverts #4456 and #4662, except a commit that is a pure refactoring (58251a9) and a commit adding behavior potentially useful when using
rvm mount(e9d9c88).cc @pkuczynski