Fix endless loop on macOS when listing remotes#4703
Merged
pkuczynski merged 4 commits intorvm:masterfrom May 28, 2019
Merged
Conversation
mpapis
previously approved these changes
May 27, 2019
Member
mpapis
left a comment
There was a problem hiding this comment.
Looks good, please fix formatting
Make sure the iterator is always incremented to prevent an endless loop if the __rvm_include_travis_binaries function returns false.
0adb144 to
706c42d
Compare
Contributor
Author
|
Travis CI failures seem unrelated, I fixed one of them in #4704. |
Contributor
Author
|
The other test failure seems to be caused by an incompatible config in Update: Proposed a fix in #4705. |
pkuczynski
previously approved these changes
May 28, 2019
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the check for Travis CI binaries returned false – as is always the case outside of Travis CI – the code could go into an endless loop, because is was continued before the iterator was incremented.