Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@curufinwe
Copy link
Collaborator

It seems that if you self-compile TF it will add a +selfbuilt string to the version. It should also be filtered out when getting the version tuple.

It seems that if you self-compile TF it will add a `+selfbuilt` string to the version. It should also be filtered out when getting the version tuple.
@curufinwe curufinwe requested review from a team, NeoLegends and albertz as code owners October 22, 2025 09:57
@curufinwe
Copy link
Collaborator Author

I think it does not like \+ inside the string. It works but we can also change it to \\+ to make the linter happy.

@albertz
Copy link
Member

albertz commented Oct 22, 2025

Did you test this? How does your version str look exactly? (Maybe also add that as a comment to the code.)
The RE would only match sth like "2.4.6-rc3+selfbuilt", right? If there is no -rc or -dev before it, it would not match.

@curufinwe
Copy link
Collaborator Author

The version string of my tensorflow package is 2.20.0-dev0+selfbuilt. I can add this example as a comment.

@albertz albertz merged commit 38ff979 into master Oct 23, 2025
63 checks passed
@albertz albertz deleted the update-get-tf-version branch October 23, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants