fix minor issues #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple fixes in here for issues that I had while installing and starting the apps.
Updated package-lock, because it was complaining about security vulnerabilities.
Fixed crash in %srrs-cli, which was caused by changes to the namespacing of chat-store in this PR: urbit/urbit#2814
Changed %srrs to use the default-agent lib for unhandled cases in on-watch and on-arvo, instead of noop-ing. Noop-ing in an on-watch arm causes the initial sole subscription to succeed, but since we don't actually send anything back to it, it ends up crashing. Noop-ing in the on-arvo arm is technically fine, but can obscure whats actually happening.