S-parameter viewer: Fixes #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was broken in the last update
It was found that when the user selected a file for deleting its data, it was not completely removed. This commit fixes that
It was found that the autoscale function in the rectangular plot widget was using a floor rounding, leading to issues with some files. Also, it was soften the limit that prevents the y-axis to be "overticked"
It was found that when a (watchable) file was created in the watched directory, it was added twice. This commit addresses this issue
…~ 360 It was found that when the trace changes from phase close to zero to phase close to 360 the polar widget showed a glitch
It was found that once the save session function didn't save the state of the chart viewers. This commit addresses this problem
The same thing as done in the rectangular plot in the previous commit
The same thing as done in the rectangular and Smith plots in the previous commits
It was found that when saving the tool state a warning showed up in the terminal because the dock objects didn't have a name. This commit fixes the problem.
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some issues detected after merging PR #1309: