Conductor and labels refactoring #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In short: - make the field with pointer to label private - add functions to control the label (set, release, remove) - manage ownership of label automatically via smart pointer All this should make working with labels easier and consistent.
In short: - Make the field with pointer to label's host private - Add setter and getter - Change label type (Node, VWire, HWire) automatically upon assigning the host
|
I have tested this and didn't find any issues. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Vadim!
#1398 is once again caused by improper memory management of labels. I've refactored control of conductor labels to make it less tedious — to avoid explicit deletes, assigning nullptrs, etc. Main character here is the
Conductorinterface which is not just a plain storage for a pointer anymore, but offers a set of methods for consistent control of labels.I've tested it a bit. It solves the problem described in #1398. I believe it should be okay overall, but can't guarantee something has not been broken. Anyway, let's give it a try, I'm here to fix in case of any problems.
Fixes: #1398