LibComp: replace 'gnd' nodes with '0' nodes #1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for finding this. But please rewrite the patch using |
This change does the same string replacement as seen in Component::getSpiceNetlist. Additionally it fixes issues seen when using the 'gnd' component with Xyce (which doesn't _natively_ use the gnd node as a global)
2001b66 to
889bfba
Compare
|
Didn't realize there was a function for that. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the same string replacement that can be seen in Component::GetSpiceNetlist, where the ground node "gnd" gets replaced by "0". This isn't an issue in NGSpice since it handles gnd as a global 0 anyways, however Xyce (by default) doesn't, so currently one can get a mix of "0" and "gnd", which then fails on Xyce.
Testbench:
Simple test schematic using IHP's PDK:
On current-branch:
This gets netlisted as:
Xsg13_lv_nmos1 0 0 gnd 0 gnd IHP_PDK_nonlinear_components_sg13_lv_nmos ...This passes simulation because we currently have two ground nodes, (hence they are connected to something), however this will not simulate as if you had these grounded.
Another possibility would be to use the option:
.PREPROCESS REPLACEGROUND TRUE, which would then according to the reference manual:With this PR:
This gets netlisted as:
Xsg13_lv_nmos1 0 0 0 0 0 IHP_PDK_nonlinear_components_sg13_lv_nmos ...Additionally I removed the double trailing whitespace, but that's more of a cosmetic fix rather than a functional one