Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ciberch
Copy link

@ciberch ciberch commented Jan 4, 2012

Allow old_secret to be optional so we don't break backwards compatibility
Fix for Issue #299

@raggi
Copy link
Member

raggi commented Jan 7, 2012

Thanks for the patches, but I want to squash this before I merge.

@ciberch
Copy link
Author

ciberch commented Jan 7, 2012

@raggi cool thanks. Here it is squashed

@raggi raggi closed this in 08e0eb0 Jan 7, 2012
@raggi
Copy link
Member

raggi commented Jan 7, 2012

Apologies, I actually rewrote your patch. Thank you for your contribution.

@ciberch
Copy link
Author

ciberch commented Jan 7, 2012

Thanks for addressing the issue. Hopefully next time Ill be able to get the
opportunity to update my pull request. I even used the IRC room to check
with manveru.

On Sat, Jan 7, 2012 at 2:53 PM, James Tucker <
[email protected]

wrote:

Apologies, I actually rewrote your patch. Thank you for your contribution.


Reply to this email directly or view it on GitHub:
#304 (comment)

@lsiden
Copy link
Contributor

lsiden commented Jan 8, 2012

Thank you @ciberch and @raggi! James, what branch did you merge this into? I don't see it yet. I'll want to update my Rack gem once it's available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants