Updated User-Agent header logic #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukuanru
approved these changes
Aug 9, 2018
50b53b9 to
78e74fa
Compare
|
@rakyll is there any chance to get this merged? Setting the user-agent would allow Flagger load generator service to work for A/B testing scenarios when the test is based on browser/os versions. Thanks |
spk
added a commit
to spk/hey
that referenced
this pull request
May 30, 2020
on command line the option -H "User-Agent: CustomUserAgent" is ignored and default user agent is always used First check if its defined then fallback to default ref rakyll#87 fix rakyll#157
rakyll
approved these changes
Mar 23, 2021
|
@rakyll Maybe, you should publish a release version. 😢 |
|
How do I implement the UA update? I tried to download the repository, but couldn't compile and run the go script. Is there any release version? |
|
This update will append the original UA so you end up with something like I just very quickly threw up a fork that will completely replace the UA, with installation instructions in the readme: |
|
Hey
Thanks for your help!
I tried installing it by following the readme instructions. While trying to
run the "go get..." I got this error:
unrecognized import path "net/http/httptrace" (import path does not begin
with hostname)
Is there anything else I should do?
Thank you
…On Thu, Dec 8, 2022 at 2:30 AM lindsey-em ***@***.***> wrote:
This update will append the original UA so you end up with something like new
ua hey/0.0.1:
// set userAgent header if set
if *userAgent != "" {
ua = *userAgent + " " + heyUA
header.Set("User-Agent", ua)
}
I just very quickly threw up a fork that will completely replace the UA,
with installation instructions in the readme:
https://github.com/lindsey-em/hey
—
Reply to this email directly, view it on GitHub
<#87 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXZ5357FRU4WR37GIL3XFVLWMET2VANCNFSM4ENOA7AQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
*ZIV ELYASHIV*
DDoS Expert
*E: ***@***.***
*M: *+972-(0)50-3213330
[image: Red Button]
[image: Under DDoS Attack? Click here for IMMEDIATE ASSISTANCE]
<https://www.red-button.net/>
*www.red-button.net* <https://www.red-button.net/>
[image: Blog] <https://www.red-button.net/blog/>
<https://www.linkedin.com/companies/red-button-ddos-experts> [image:
youtube] <https://www.youtube.com/channel/UCNDr_afX7_e-ityDrjF5DBQ>
This e-mail message may contain confidential or legally privileged
information and is intended only for the use of the intended recipient(s).
Any unauthorized disclosure, dissemination, distribution, copying or the
taking of any action in reliance on the information herein is prohibited.
E-mails are not secure and cannot be guaranteed to be error free as they
can be intercepted, amended, or contain viruses. Anyone who communicates
with us by e-mail is deemed to have accepted these risks. Red Button is not
responsible for errors or omissions in this message and denies any
responsibility for any damage arising from the use of e-mail. Any opinion
and other statement contained in this message and any attachment are solely
those of the author and do not necessarily represent those of the company.
|
chunter0
pushed a commit
to chunter0/hey
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Request:
The User-Agent header was not set when passed as a HTTP header param. Added the ability to set User-Agent via header and/or separate CLI parameter
-U.