Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added Dockerfile #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rakyll merged 1 commit into from
Nov 25, 2020
Merged

Added Dockerfile #226

rakyll merged 1 commit into from
Nov 25, 2020

Conversation

@jnovack
Copy link
Contributor

@jnovack jnovack commented Nov 21, 2020 •
edited
Loading

There were quite a number of issues with the other PR (no offense) so I just rewrote it.

  • Non-root application user for security.
  • Docker container labels.
  • ca-certificates in the event https connections need them.
  • Multi-stage build to scratch for the smallest image possible
    image

Before Merging, you may wish to:

  • Update the Author label line, I'm not sure how you like to see your name or handle.
  • Remove ca-certificates lines if you are sure they are unused (I can never be sure).
  • Add RUN go test prior to the build (after go mod download).

@jnovack
Create Dockerfile
0dfdc68 
Added Dockerfile
@rakyll
Copy link
Owner

rakyll commented Nov 25, 2020

We can merge this. cc @solsson, please don't spend time on the previous PR.

@rakyll rakyll merged commit cd86a70 into rakyll:master Nov 25, 2020
@jnovack jnovack deleted the patch-1 branch November 25, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakyll rakyll rakyll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnovack @rakyll