Renamed props to propOf, reimplemented props as multiple prop#501
Merged
CrossEye merged 1 commit intoramda:masterfrom Nov 9, 2014
anton-rudeshko:props
Merged
Renamed props to propOf, reimplemented props as multiple prop#501CrossEye merged 1 commit intoramda:masterfrom anton-rudeshko:props
props to propOf, reimplemented props as multiple prop#501CrossEye merged 1 commit intoramda:masterfrom
anton-rudeshko:props
Conversation
ramda.js
Outdated
Contributor
Author
There was a problem hiding this comment.
Ouch, copy pasted. Sorry, will fix, thank you.
Contributor
Author
|
Updated. |
Member
There was a problem hiding this comment.
prop is manually curried since it is a critical path and we wanted to squeeze as many cycles out as possible. i think using curry methods makes sense until we know we need to optimize. this looks really good to me.
Member
|
👍 |
Member
|
🌳 |
CrossEye
added a commit
that referenced
this pull request
Nov 9, 2014
Renamed `props` to `propOf`, reimplemented `props` as multiple `prop`
Member
|
LGTM |
Contributor
Author
|
AWSM, thank you all. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #499.