added eqDeep#718
Conversation
src/internal/_eqDeep.js
Outdated
There was a problem hiding this comment.
House style only uses while loops. While this has never been a formal requirement of Ramda code, I think we're pretty loathe to change it.
Usually:
var idx = -1;
while (++idx < bound) { /* ... */ }
|
I've made the changes to the loops and added some tests that I forgot to include the first time. |
|
Still not quite our usual style, but LGTM. Any other thoughts? @buzzdecafe? @davidchambers? |
dist/ramda.js
Outdated
There was a problem hiding this comment.
should be hasOwnProperty not simple in
|
Ok, I made the changes, It works with regexs, dates and typed arrays now. |
|
🌳 Let's merge this and publish 0.9.0. :) |
test/eqDeep.js
Outdated
There was a problem hiding this comment.
This will cause the tests to fail in old browsers, I believe.
/cc @buzzdecafe
There was a problem hiding this comment.
@davidchambers Would there be problems with wrapping that test case in an if?
if (ArrayBuffer) {
// typed array tests
}There was a problem hiding this comment.
You'd need something like this:
if (typeof ArrayBuffer !== 'undefined' && typeof Int8Array !== 'undefined') {
// ...
}This seems like a reasonable approach.
|
This sounds good to me. Anyone have objections to merging as is? |
|
🍰 |
There was a problem hiding this comment.
These assertions should either be uncommented or removed.
There was a problem hiding this comment.
The idea was to leave them as reminders to attach them when we are properly able to run them: #718 (comment)
Do you have serious reservations? I would love it if we could get 0.9.0 out the door this weekend. And I think this is the only major item left.
There was a problem hiding this comment.
The idea was to leave them as reminders to attach them when we are properly able to run them
I see. I had missed that comment.
Do you have serious reservations?
No.
There are merge conflicts (likely just in dist/ramda.js). I'm happy to resolve the merge conflicts and push the updated commit to master, if you like.
|
Could you resolve the merge conflicts, @davidrusu? I'll merge this once you have done so. :) |
|
@davidchambers sure |
Discussion at (#699)