Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added eqDeep#718

Merged
davidchambers merged 1 commit intoramda:masterfrom
davidrusu:eqDeep
Jan 24, 2015
Merged

added eqDeep#718
davidchambers merged 1 commit intoramda:masterfrom
davidrusu:eqDeep

Conversation

@davidrusu
Copy link
Contributor

Discussion at (#699)

@davidrusu davidrusu changed the title (#699) added eqDeep added eqDeep Jan 11, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

House style only uses while loops. While this has never been a formal requirement of Ramda code, I think we're pretty loathe to change it.

Usually:

var idx = -1;
while (++idx < bound) { /* ... */ }

@davidrusu
Copy link
Contributor Author

I've made the changes to the loops and added some tests that I forgot to include the first time.

@CrossEye
Copy link
Member

Still not quite our usual style, but LGTM.

Any other thoughts? @buzzdecafe? @davidchambers?

dist/ramda.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be hasOwnProperty not simple in

@davidchambers davidchambers added this to the 0.9.0 milestone Jan 13, 2015
@davidrusu
Copy link
Contributor Author

Ok, I made the changes, It works with regexs, dates and typed arrays now.

@davidchambers
Copy link
Member

🌳

Let's merge this and publish 0.9.0. :)

test/eqDeep.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause the tests to fail in old browsers, I believe.

/cc @buzzdecafe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidchambers Would there be problems with wrapping that test case in an if?

if (ArrayBuffer) {
    // typed array tests
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need something like this:

if (typeof ArrayBuffer !== 'undefined' && typeof Int8Array !== 'undefined') {
    // ...
}

This seems like a reasonable approach.

@CrossEye CrossEye mentioned this pull request Jan 22, 2015
@CrossEye
Copy link
Member

This sounds good to me. Anyone have objections to merging as is?

@buzzdecafe
Copy link
Member

🍰

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These assertions should either be uncommented or removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to leave them as reminders to attach them when we are properly able to run them: #718 (comment)

Do you have serious reservations? I would love it if we could get 0.9.0 out the door this weekend. And I think this is the only major item left.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to leave them as reminders to attach them when we are properly able to run them

I see. I had missed that comment.

Do you have serious reservations?

No.

There are merge conflicts (likely just in dist/ramda.js). I'm happy to resolve the merge conflicts and push the updated commit to master, if you like.

@davidchambers
Copy link
Member

Could you resolve the merge conflicts, @davidrusu? I'll merge this once you have done so. :)

@davidrusu
Copy link
Contributor Author

@davidchambers sure

davidchambers added a commit that referenced this pull request Jan 24, 2015
@davidchambers davidchambers merged commit d93c220 into ramda:master Jan 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants