[2.5.x] GKE MasterAuthorizedNetwork Tweaks #4560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if private endpoint is enabled master auth networks must be enabled too rancher/rancher#32251
out of scope of the ui requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pr adds logic to prevent the master authorize networks from be disabled if the enablePrivateEndpoint param is set true. If not the field is optional.
Additionally this reverts the changes for InputCidr min max validation as this logic is just not robust enough to handle the validation correctly.
Sets node pool auto upgrade and auto repair true by default as this is what is done in GKE.
Adds links to GKE docs.
Types of changes
Bugfixes
Linked Issues
rancher/rancher#32251
rancher/rancher#32207
rancher/rancher#32030
Further comments