fix eks edit removal of agent config fields #5031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand the change and I'm okay with it going in. I had one question though. Does the backend return the null values? |
|
The null values are included in the response, then gone when re-querying for the cluster |
codyrancher
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rancher/dashboard#8968 (comment)
When EKS clusters are edited, only changed values are sent in the request and the rest are preserved (more info on why here). When a user clears out previously-defined cluster/fleet agent customization the relevant fields are deleted from the cluster spec; consequently, with imported EKS clusters specifically, the previously-set values are preserved.
This PR updates the EKS cluster save function to set any cluster/fleet agent fields the user has cleared out to
null, which will properly overwrite the previous value.I found another bug in the same area (editing agent config) that appears to have a different underlying cause, issue here: rancher/dashboard#9003
Testing