fix: remove fee parameters from signing message #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
46c4de4 to
76fa41b
Compare
azixus
approved these changes
Sep 5, 2025
Comment on lines
99
to
104
| params.amountOut, | ||
| params.srcChainId, | ||
| params.dstChainId, | ||
| params.verificationFee, | ||
| params.solverFee, | ||
| params.nonce, | ||
| params.executed, | ||
| ) | ||
| .abi_encode() |
Contributor
There was a problem hiding this comment.
For reference, this message is not unique per-router contract => two routers contracts on the same chain would result in the same message. This may allow re-using the signature to fulfill the swap using another router contract on the same chain (and, with the same signature scheme).
Contributor
Author
There was a problem hiding this comment.
have raised an issue for this https://github.com/randa-mu/onlysubs-planning/issues/127
76fa41b to
7ffa84a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #69
nice