feat(parse): add switches and params for src-block #91
Conversation
🦋 Changeset detectedLatest commit: 041eb97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 96.31% 96.32%
=======================================
Files 15 15
Lines 1820 1822 +2
Branches 599 601 +2
=======================================
+ Hits 1753 1755 +2
Misses 66 66
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
packages/uniorg-parse/src/parser.ts
Outdated
| affiliated, | ||
| language, | ||
| switches: switches?.trim(), | ||
| parameters: parameters !== '' ? parameters?.trim() : undefined, |
There was a problem hiding this comment.
I am not sure if this is the API that you want, but otherwise this impacts all the other tests, as parameters is an empty string when no parameters are found.
There was a problem hiding this comment.
I believe unified requires all data to be json-serializable, which means undefined values are not allowed. It's better to return null even if it means updating old tests
|
Thanks for your pull request! |
|
This is now released as [email protected] |
Exposes switches and parameters of the
src-block, so we can reference these later in the pipeline.Reason?
I depend on
:exports noneto prep some data behind the scenes, that I don't want to expose to the reader.