fix(orgx): include types in published package #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 92077e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@Sorixelle is attempting to deploy a commit to the rasendubi's projects Team on Vercel. A member of the Team first needs to authorize it. |
Merged
|
@Sorixelle thanks for the fix! This has been released in @uniorgjs/[email protected] and the release seems to include type directory now: https://www.npmjs.com/package/@uniorgjs/orgx/v/2.0.1?activeTab=code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@uniorgjs/orgxfrom NPM seems to be missing it's built type declarations. I think this is because the types are included in the package's.gitignoreso they don't get committed, but unfortunatelypnpm publishalso uses the.gitignoreto determine what files get included in the published package, leading to the types not getting distributed.This PR should fix the problem by including an empty
.npmignore, which will override the.gitignorefile during publish and include the types in published packages again (docs).