Deallocation should be noexcept#1416
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.12from Oct 9, 2025
Merged
Conversation
bdice
commented
Oct 9, 2025
| void do_deallocate(void* ptr, std::size_t size, rmm::cuda_stream_view) override | ||
| void do_deallocate(void* ptr, std::size_t size, rmm::cuda_stream_view) noexcept override | ||
| { | ||
| if (munmap(ptr, size) == -1) { RAFT_FAIL("huge_page_resource::munmap"); } |
Contributor
Author
There was a problem hiding this comment.
This function must be made noexcept. Throwing in noexcept code forces std::terminate, so this RAFT_FAIL will trigger that. I don't know if this error message will be displayed, but my suspicion is that it won't show up. The right solution is probably to adopt a macro that outputs to std::cerr before throwing/terminating rather than relying on the C++ exception message to show? We have had to do similar tricks with RMM_ASSERT_CUDA_SUCCESS because it can't throw in noexcept functions.
Since this fix is probably necessary to unblock builds (and I need to file similar fixes for other repos), I am leaving this as a follow-up task for the cuVS team to handle whichever way they prefer.
Member
There was a problem hiding this comment.
Can you capture this in an issue?
divyegala
approved these changes
Oct 9, 2025
Contributor
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
A follow-up fix for #1416 Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Divye Gala (https://github.com/divyegala) URL: #1417
robertmaynard
pushed a commit
to robertmaynard/cuvs
that referenced
this pull request
Oct 10, 2025
Update for compatibility with rapidsai/rmm#2077. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#1416
robertmaynard
pushed a commit
to robertmaynard/cuvs
that referenced
this pull request
Oct 10, 2025
A follow-up fix for rapidsai#1416 Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#1417
julianmi
pushed a commit
to julianmi/cuvs
that referenced
this pull request
Oct 13, 2025
Update for compatibility with rapidsai/rmm#2077. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#1416
julianmi
pushed a commit
to julianmi/cuvs
that referenced
this pull request
Oct 13, 2025
A follow-up fix for rapidsai#1416 Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#1417
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Oct 22, 2025
Update for compatibility with rapidsai/rmm#2077. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#1416
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Oct 22, 2025
A follow-up fix for rapidsai#1416 Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#1417
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for compatibility with rapidsai/rmm#2077.