Add patch for FAISS memory resources#1477
Merged
rapids-bot[bot] merged 2 commits intorapidsai:mainfrom Oct 31, 2025
Merged
Conversation
divyegala
approved these changes
Oct 29, 2025
tarang-jain
approved these changes
Oct 30, 2025
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a patch to update FAISS to use RMM's new CCCL-aligned memory resource APIs. We can upstream this patch when FAISS is adopting RAPIDS 25.12+. This patch wouldn't work with the current upstream pinning of RAPIDS 25.08, so I don't think upstreaming it would be beneficial yet.
Changes
rmm::mr::pinned_memory_resourcetormm::mr::pinned_host_memory_resourcermm::mr::pinned_memory_resourcein favor ofrmm::mr::pinned_host_memory_resource. rmm#2090