Fix golang test name and add more logging and error checking.#1471
Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom Oct 28, 2025
Merged
Fix golang test name and add more logging and error checking.#1471rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
Conversation
Member
|
/ok to test 584d6ee |
benfred
approved these changes
Oct 28, 2025
| queries, err := cuvs.NewTensor(testDataset[:nQueries]) | ||
| if err != nil { | ||
| t.Fatalf("error creating queries tensor: %v", err) | ||
| } |
Member
There was a problem hiding this comment.
thanks for adding the error checking here -
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The golang brute_force_test is wrongly named. This pull request fixes it. It was forked from the Cagra test and the name was likely never updated.
Also returning and checking some more of the errors and giving more useful error messages